Skip to content

Feature/lynnt lightcalorimetry clean, production gen2#930

Merged
nathanielerowe merged 92 commits intoproduction/sbnd-gen2from
feature/lynnt_lightcalorimetry_clean
May 7, 2026
Merged

Feature/lynnt lightcalorimetry clean, production gen2#930
nathanielerowe merged 92 commits intoproduction/sbnd-gen2from
feature/lynnt_lightcalorimetry_clean

Conversation

@lynnt20
Copy link
Copy Markdown
Contributor

@lynnt20 lynnt20 commented May 6, 2026

No description provided.

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- moved truth validation to a separate function
- added lower/upper threshold for PE per channel
- added fcl param to turn on/off evaluating all planes
- option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet
- merge the two previous trees into one
- match-type can now differentiate between event/slice level easily
Version v09_89_01, patch release for SBN2024A
lynnt20 and others added 25 commits January 15, 2026 15:19
…ghted avg fix

- BCFM has at most, one bcfm<->one slice <-> one opflash association, even if there are opflashes in both tpcs. Explicitly look for an opflash (within a fcl parameter window) in the opposite TPC if the slice has spacepoints in both TPCs
- bug fix for weighted average; need to treat each TPC as independent for calculating the weighted avg
…ghted avg fix

- BCFM has at most, one bcfm<->one slice <-> one opflash association, even if there are opflashes in both tpcs. Explicitly look for an opflash (within a fcl parameter window) in the opposite TPC if the slice has spacepoints in both TPCs
- bug fix for weighted average; need to treat each TPC as independent for calculating the weighted avg
- add to standard mc/data reco2 workflow
- add SCE tag to cafmaker sce for data and mc
…to some fcl comments

- also remove unused functions
@nathanielerowe nathanielerowe marked this pull request as ready for review May 6, 2026 21:52
@nathanielerowe nathanielerowe requested a review from linyan-w May 6, 2026 21:52
@nathanielerowe nathanielerowe merged commit 109ab43 into production/sbnd-gen2 May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants